Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: addProseMirrorPlugins fires twice at editor initialization #4257

Closed
1 of 2 tasks
Nantris opened this issue Jul 27, 2023 · 4 comments
Closed
1 of 2 tasks

[Bug]: addProseMirrorPlugins fires twice at editor initialization #4257

Nantris opened this issue Jul 27, 2023 · 4 comments
Labels
Triage: Open A new issue or pullrequest that requires triage (added by default)

Comments

@Nantris
Copy link
Contributor

Nantris commented Jul 27, 2023

Which packages did you experience the bug in?

extension-link

What Tiptap version are you using?

2.1.0-rc.12

What’s the bug you are facing?

I am reporting this specifically for extension-link but it may to be more wide ranging than that.

Note the plugin keys have 1 appended to them on the second run. I can't determine if this really means the plugin is loaded twice or if it matters in practice.

debugger hit 1

image

debugger hit 2

image

What browser are you using?

Chrome

Code example

No response

What did you expect to happen?

addProseMirrorPlugins should only run one time.

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@Nantris Nantris added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug labels Jul 27, 2023
@Nantris
Copy link
Contributor Author

Nantris commented Jul 27, 2023

This seems to affect all nodes which you use the .extend() functionality on. When it runs a second time the keys change from like codeBlockVSCodeHandler$ to codeBlockVSCodeHandler$1. I assume that means these are being loaded twice?

@Nantris Nantris changed the title [Bug]: addProseMirrorPlugins can fire repeatedly at editor initialization [Bug]: addProseMirrorPlugins fires twice at editor initialization Jul 27, 2023
@bdbch bdbch removed Type: Bug The issue or pullrequest is related to a bug Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. labels Dec 14, 2023
@634750802
Copy link

Maybe related to #5136

@Nantris
Copy link
Contributor Author

Nantris commented May 12, 2024

@634750802 that does seem related, but it should probably be filed as an issue, not a discussion. I guess the maintainers can probably change that though if they see fit.

@nperez0111
Copy link
Contributor

This should be fixed with version 2.4.0, feel free to try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage: Open A new issue or pullrequest that requires triage (added by default)
Projects
Status: Done
Development

No branches or pull requests

5 participants