Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ts error for BubbleMenu and FloatingMenu in @tiptap/react #5126

Merged
merged 1 commit into from
May 10, 2024

Conversation

c0sc0s
Copy link
Contributor

@c0sc0s c0sc0s commented May 9, 2024

Please describe your changes

useEditor return type is Editor | null
image
But FloatingMenu and BubbleMenu 's props of editor is Editor | undefined
I have solved it.

[add a description of your changes here]
Change FloatingMenu and BubbleMenu 's props of editor from Editor | undefined to Editor | null

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

[add a link to the related issues here]

Copy link

netlify bot commented May 9, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 248933d
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/663c3166ce37a00008f1e06b
😎 Deploy Preview https://deploy-preview-5126--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdbch bdbch merged commit baff4af into ueberdosis:main May 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants