Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard does not work correctly #138

Closed
ueman opened this issue Nov 12, 2021 · 7 comments
Closed

Clipboard does not work correctly #138

ueman opened this issue Nov 12, 2021 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@ueman
Copy link
Owner

ueman commented Nov 12, 2021

Currently, the clipboard does work correctly in the feedback bottom sheet.
This can be fixed by changing this line to, for example, 0.7.

This kinda makes me think that this is caused by the Navigator being bigger than the clickable/touchable area of the bottom sheet. Thus, the clipboard menu can be placed where it can't be clicked.

@ueman ueman added the bug Something isn't working label Nov 12, 2021
@ueman ueman self-assigned this Nov 12, 2021
@ueman
Copy link
Owner Author

ueman commented Nov 15, 2021

After investigating some more, I think this is an issue with the way the navigator is used.
If the navigator covers the whole screen, the clipboard works as expected. However, the navigator doesn't allow click through, which makes it impossible to use anything else than the bottom sheet.

@diegoveloper
Copy link
Contributor

@ueman did you report this issue on the Flutter repo?, maybe the could help :D

@ueman
Copy link
Owner Author

ueman commented Nov 15, 2021

@diegoveloper Not yet, but I'll try to create a simple example which reproduces this. In the meantime, I think I have solution, but I need to test it, to be sure that I don't break anything else :D

@ueman
Copy link
Owner Author

ueman commented Nov 17, 2021

Moving the usage of the Navigator up the tree in the package breaks Navigator.of(context, rootNavigator: true) calls of users of this library but fixes the problem. Therefor, I think I shouldn't make this change.

I'll need to create a reproducible example and create an issue in the flutter repo, so that it gets fixed there.

@ueman
Copy link
Owner Author

ueman commented Dec 30, 2021

This seems to be fixed by #149

@ueman ueman closed this as completed Dec 31, 2021
@diegoveloper
Copy link
Contributor

Hello @ueman , can you add a comment here when you release a new version? (just to be notified) Thanks :D

@ueman
Copy link
Owner Author

ueman commented Dec 31, 2021

I've already released it as a beta version: https://pub.dev/packages/feedback/versions/2.3.0-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants