Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

'n'/'N' keys should be ignored until '/' is pressed #396

Closed
AlexeySachkov opened this issue May 16, 2018 · 3 comments · Fixed by #414
Closed

'n'/'N' keys should be ignored until '/' is pressed #396

AlexeySachkov opened this issue May 16, 2018 · 3 comments · Fixed by #414
Labels
Milestone

Comments

@AlexeySachkov
Copy link
Contributor

I'm opening this issue because:

  • I'll report a minor issue

Description

Red overlay block appears if you typed n/N before /

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Open any site (https://github.com)
  2. Press n or N
  3. You will see the following: image

I think we should ignore n/N until search is started.

System configuration

  • Operating system: Windows 10
  • Firefox version: 60.0
  • Vim-Vixen version: 0.12
@ueokande ueokande modified the milestones: 0.13, 0.15 May 22, 2018
@ueokande ueokande added the bug label May 22, 2018
@ueokande
Copy link
Owner

Vim says when n pressed with no previous searchs:

E35: No previous regular expression

Vim Vixen should say such messages (e.g. "No previous search"...)

@AlexeySachkov
Copy link
Contributor Author

@ueokande, looks like my vim saves last searched pattern somewhere. Even when I close the vim and reopen it again I cannot see message "No previous regular expression"

But i'm okay with something like "No previous search" instead of "Pattern not found: null". Looks more user-friendly

@ueokande
Copy link
Owner

current message expose the internal implementation. I'll fix it in the next version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants