-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional jump or move depends on uninitialised value #23
Comments
Hi, the issue is in the public-domain code performing LZMA (de)compression (we use it to compress the parts of the models where it make sense). The same code is also in UDPipe 1, MorphoDiTa, ... . As you say, I am not sure how difficult will be to find the cause (given that it is someone else's code), but I will try to do it next week (and do minor releases with the fix). |
That would be great! Thanks for the effort. |
Hi, after investigation, I believe it is just a false positive report by valgrind (the code actually does read an uninitialized value, but the conditional jump is guarded by other conditions, so the program behavior cannot be influenced by the unitialized value). I tried to fix the problem by ufal/cpp_utils@fc215c8 (on g++-10 and clang-11 the valgrind report disappeared) and then updated Could you please try building the nametag R wrapper to verify the problem is really solved? Thanks! |
Many thanks for the fixes and your time. I've incorporated the changes and uploaded to CRAN. It's currently under CRAN review. What I did already got as feedback from CRAN is that I had to replace std::interator as it is deprecated in C++17 and future compilers will not support C++11. I'll make a new issue for this if you don't mind. I'll keep you updated here if I have more feedback from CRAN.
|
The R package was accepted on CRAN yesterday including the fix for this issue which incorporated your changes of 294466f. |
Hello foxik.
In 2020 I've created an R wrapper around the nametag library. It's on CRAN since June 2020 (https://cran.r-project.org/package=nametagger).
Recently the CRAN build system has changed and the build log at CRAN shows that a valgrind issue has appeared at ufal::nametag::utils::lzma::MatchFinder_Create(
Although in the R package (at https://github.com/bnosac/nametagger) I use commit 598666b of nametag, I think the issue is still there in the current version of nametag.
Not sure how difficult it is to fix this.
The text was updated successfully, but these errors were encountered: