Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env setup script #4

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

env setup script #4

wants to merge 11 commits into from

Conversation

dougolw
Copy link

@dougolw dougolw commented Sep 6, 2022

No description provided.

@matheusrod98 matheusrod98 linked an issue Sep 24, 2022 that may be closed by this pull request
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
@matheusrod98
Copy link
Member

We should also check if the distro is inside WSL2, something like this:

if wsl
    check_distro
        install_bunch_of_stuff
else
    check_distro
        install_bunch_of_stuff

This is necessary because we shouldn't install Docker while in WSL2. Just install Docker Desktop.
Also, put a message to install Docker Desktop when in WSL2.

@matheusrod98
Copy link
Member

Also add OpenSuse and Linux Mint

@dougolw
Copy link
Author

dougolw commented Oct 10, 2022

We should also check if the distro is inside WSL2, something like this:

if wsl
    check_distro
        install_bunch_of_stuff
else
    check_distro
        install_bunch_of_stuff

This is necessary because we shouldn't install Docker while in WSL2. Just install Docker Desktop. Also, put a message to install Docker Desktop when in WSL2.

What should be installed on the subsystem?

@matheusrod98
Copy link
Member

We should also check if the distro is inside WSL2, something like this:

if wsl
    check_distro
        install_bunch_of_stuff
else
    check_distro
        install_bunch_of_stuff

This is necessary because we shouldn't install Docker while in WSL2. Just install Docker Desktop. Also, put a message to install Docker Desktop when in WSL2.

What should be installed on the subsystem?

We should also check if the distro is inside WSL2, something like this:

if wsl
    check_distro
        install_bunch_of_stuff
else
    check_distro
        install_bunch_of_stuff

This is necessary because we shouldn't install Docker while in WSL2. Just install Docker Desktop. Also, put a message to install Docker Desktop when in WSL2.

What should be installed on the subsystem?

Just remove everything related to Docker and it should be fine.

@dougolw
Copy link
Author

dougolw commented Oct 10, 2022

@matheusrod98 , If the subsystem is using some other distro probably the logic would be to check the distro for the subsystem too, what do you think?

@matheusrod98
Copy link
Member

@matheusrod98 , If the subsystem is using some other distro probably the logic would be to check the distro for the subsystem too, what do you think?

Exaclty, because there is many WSL distros, even arch. But all of them has the /etc/os-release file.

You could also use this to check for WSL2:

 kernel=$(uname -r | tr '[:upper:]' '[:lower:]')
   if [[ $kernel == *"microsoft"* ]]; then
     export IS_WSL="true"
   else
     export IS_WSL="false"
   fi

@dougolw dougolw changed the title test model env setup script Oct 11, 2022
Copy link
Member

@matheusrod98 matheusrod98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some variables and function names that are not meaningful enough. Everything else is fine.

You were able to test in WSL2? If not I can find someone to do it.

install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
@dougolw
Copy link
Author

dougolw commented Oct 11, 2022

Just some variables and function names that are not meaningful enough. Everything else is fine.

You were able to test in WSL2? If not I can find someone to do it.

unfortunately no. Im suffering from the lack of tests to be honest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a bash script to setup the dev environment for new members
2 participants