-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
env setup script #4
base: master
Are you sure you want to change the base?
Conversation
We should also check if the distro is inside WSL2, something like this:
This is necessary because we shouldn't install Docker while in WSL2. Just install Docker Desktop. |
Also add OpenSuse and Linux Mint |
What should be installed on the subsystem? |
Just remove everything related to Docker and it should be fine. |
…2);user to docker group
@matheusrod98 , If the subsystem is using some other distro probably the logic would be to check the distro for the subsystem too, what do you think? |
Exaclty, because there is many WSL distros, even arch. But all of them has the You could also use this to check for WSL2:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some variables and function names that are not meaningful enough. Everything else is fine.
You were able to test in WSL2? If not I can find someone to do it.
unfortunately no. Im suffering from the lack of tests to be honest |
No description provided.