-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
injection failing using compilation server #53
Comments
What is the error? |
hello @kevinresol . |
Hm, maybe a minject bug? |
Can you reduce it to a minimal example and see if it is minject or ufront problem |
sorry for the late reply. |
btw i've just tried minject alone with compilation server and it works fine. so it's definitely a ufront bug we got here. |
fyi first two compilations work fine but then ... compilation runs ok but injected variable is null |
This should be haxe-related. |
ok i've seen this! let the masters do their macro compiler Magic :) |
Edit: I think Simn has figured out already. So no worry. |
It turns out that it is not haxe's problem but minject's was coded in a way that is not compatible with the compilation server. I have pushed a fix to here. That works, but it is not optimal. Because it uses onGenerate to modify the meta and onGenerate loops through all types, even they are already cached by the compilation server. Therefore I have changed onGenerate to use tink_syntaxhub (here), which will make it only process uncached types. I will keep this open until the fix got merged into upstream minject |
Thanks for looking into this @kevinresol. Let's see if the team at Massive Interactive are happy to merge. Hopefully! |
minimalistic example failing with compilation server. works good without
https://gist.github.com/postite/2059bc4600f8115a8469
bug or what ?
The text was updated successfully, but these errors were encountered: