Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUFR Processing tasks are needed for RRFS #486

Closed
christinaholtNOAA opened this issue Nov 16, 2022 · 4 comments · Fixed by #636
Closed

BUFR Processing tasks are needed for RRFS #486

christinaholtNOAA opened this issue Nov 16, 2022 · 4 comments · Fixed by #636
Assignees
Labels
enhancement New feature or request

Comments

@christinaholtNOAA
Copy link
Collaborator

Description

RRFS runs several executables included with rrfs-utl as a preparation of existing RAP bufr files. This task corresponds to a task in RRFS_dev1 named process_bufr. It does the following:

  • Run process_Lightning.exe on files like *lghtng.tm00.bufr_d
  • Run process_larccld.exe on files like *lgycld.tm00.bufr_d
  • Run process_metarcld.exe on files like *prepbufr.tm00

Solution

Use the RRFS_dev1 version of this task as a guide to a solution. Include any necessary default configuration settings, add j-jobs, and ex-scripts, and hook them into the workflow.

These tasks have no dependencies other than data retrieval, so should be able to stand alone as a full workflow without other components.

Requirements**

  • All contributions must be machine independent and follow the style and guidelines of the SRW App.
  • The contributed scripts must be tested, and new tests should be contributed for SRW. These WE2E tests can be short and only include data retrieval and running the task.

Acceptance Criteria (Definition of Done)

Matches answers obtained in RRFS. Please reach out to someone at NOAA GSL to help with this test case.

@christinaholtNOAA
Copy link
Collaborator Author

@danielabdi-noaa Has the scripts, and can test it standalone, but won't add it to a workflow in that PR.

@MichaelLueken MichaelLueken linked a pull request Mar 6, 2023 that will close this issue
37 tasks
@christinaholtNOAA
Copy link
Collaborator Author

PR has j-job, ex-script, and config settings.

Tested as part of a bigger PR, and it works as expected.

@christinaholtNOAA
Copy link
Collaborator Author

Ready for re-review.

@christinaholtNOAA
Copy link
Collaborator Author

Merged in develop. Ready for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants