Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #4056 #4075

Closed
wants to merge 1 commit into from
Closed

Fix issue #4056 #4075

wants to merge 1 commit into from

Conversation

iia
Copy link

@iia iia commented Apr 3, 2018

Adding and modifying a hash's value didn't work from the GUI as the validation was only done on the key and not on the value. The validation sets the value of the fields which was always empty for the value field as the validation was not done for the value field. This PR fixes issue#4056.

@uglide
Copy link
Collaborator

uglide commented Apr 4, 2018

Hello,
Thaks for PR, but your fix doesn't cover the case when user sets empty hash value

@uglide uglide closed this Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants