Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash at "database from folder" creation #9

Open
MisesEnForce opened this issue Feb 6, 2022 · 2 comments
Open

Crash at "database from folder" creation #9

MisesEnForce opened this issue Feb 6, 2022 · 2 comments

Comments

@MisesEnForce
Copy link

MisesEnForce commented Feb 6, 2022

I am using Kombilo's last windows binaries (provided at https://dl.u-go.net/kombilo/kombilo-084.app.zip).

I have an .sgf files folder containing 101216 .sgf files (min file size is 1Kb, max size is 3kb).

From Kombilo "Database-->Edit DB List" I open the "Edit database list" window, I do "Add Db", point to the aforementionned folder and parametrize the rest as follows :

image

Then in Kombilo's main windows the bar at the bottom right fills up until the end, until a "Finalizing ... (this will take some time)" appears in the log part from the "Edit Database list window" and when this finishes (or seems to finish), Kombilo crashes in a way that all Kombilo windows are simply instantaneously closed.

Looking in the folder to see if any database files have been provided, I see .db, .db1 and .da etc files, but when I want to open the database in q5go, the database file look like being corrupted. (I compiled q5go myself with Qt 5.12.12 without any issue, and it opened many other databases without any problem.)

I then took 1212 random .sgf files from the big folder, put them in another folder and did the same as I did above with that new small folder and had the exact same issue.

What I described above happens on a 32Gb core i7 laptop as well as on a 64Gb core i9 desktop. On both computers I monitored (with win sysinternals process explorer) the RAM used by Kombilo during the database conversion process up to the crash, it has never exceeded the 600-700Mb range, but the RAM used steadily grows until the crash. A memory leak perhaps ?

@sean51623
Copy link

From this thread: https://www.lifein19x19.com/forum/viewtopic.php?f=18&t=17205
libkombilo/pattern.h:const int DATE_PROFILE_END = 2020;

This seems to be the root-cause to the crash. I am also experiencing the same thing on Windows, and the author replies in the thread link above.

@MisesEnForce
Copy link
Author

MisesEnForce commented Apr 3, 2022

Thank you for pointing me to https://www.lifein19x19.com/forum/viewtopic.php?f=18&t=17205 !

But I don't think that this is the critical issue for my problem -- or at least not as simply as that.

Indeed :

  • I git cloned the kombilo repo,
  • replaced const int DATE_PROFILE_END = 2020; with const int DATE_PROFILE_END = 9999; (I also tried with 2100 instead of 9999, same result.)
  • then added shell.c, sqlite3.c, sqlite3.h and sqlite3ext.h from the amalgation zip from [https://www.sqlite.org/download.html](sqlie url) inside kombilo\kombilo\libkombilo,
  • downloaded boost 1.62.0 and modified the kombilo\setup.py to point towards it
  • and finally ran python setup.py build inside kombilo (the log of the build is attached).
    log.txt

This created, in kombilo a build folder containing two folders temp.win-amd64-3.8 and lib.win-amd64-3.8. (I am surprised that the exe wasn't built, but only libraries. Maybe there is another command than the python setup.py build I ran, but I did not manage to find them as nothing for buidling on windows is documented ...)

I then went to where I installed kombilo when I used https://dl.u-go.net/kombilo/kombilo-084.exe, that is, inside the kombilo08 folder from C:\Program Files. This folder contains a kombilo whose contents I backed up and replaced with what was built inside the lib.win-amd64-3.8.

I then ran kombilo08\kombilo.exe and ...

... experienced the very same I already described in my initial post ...

So either DATE_PROFILE_END issue is not the real one, or I am not properly building kombilo from source. But hey, I would I know if I am building it properly from source or not as there is no indication about how one should build it from source on windows ...

Remark : all occurences of DATE_PROFILE_END in kombilo's source are :
image
so that I don't think any other related modification should be done.

////////////////////////////////////////////////////////////////////////////////////////////////////

I sent a mail on april the 3rd, 2022 to the developer regarding this crash, no answer so far.

////////////////////////////////////////////////////////////////////////////////////////////////////

April the 25th, 2022 : still no answer from the developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants