New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tighten up Object.values and Object.entries types #42

Open

uhyo wants to merge 1 commit into master from fix/40

Owner

uhyo commented Jul 7, 2024

closes #40

This fix tightens up Object.values and Object.entries types so that:

Object.values({}) returns unknown[] (previously never[])
Object.values({ foo: 123 }) returns unknown[] (previously number[])

To get non-unknown[] results you need to pass a value of type Record<string, T>.

const obj: Record<string, number> = { foo: 123 };

Object.values(obj) // number[]

This isn't still perfect but less unsafe than before.


          fix: tighten up Object.values and Object.entries types to infer unknw…

804fef9

…on in more cases

uhyo self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment