Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OccultMania prefer to become Diviner while he could also become Werewolf #397

Closed
Sunev opened this issue Nov 20, 2018 · 2 comments
Closed

Comments

@Sunev
Copy link
Contributor

Sunev commented Nov 20, 2018

Imagine a Werewolf who got a gift of Diviner set from Merchant.
In such a situation, following lines determine that the OccultMania will become a Diviner, while his target's main job is Werewolf.

        if p.isJobType "Diviner"
            type="Diviner"
        else if p.isWerewolf()
            type="Werewolf"

This is somewhat counterintuitive.
Is there any good solution for this?

@Sunev
Copy link
Contributor Author

Sunev commented Nov 20, 2018

@uhyo
Copy link
Owner

uhyo commented Nov 20, 2018

Yes, I think the OccultMania should become a Werewolf in that case.
As we do not have "Werewolf set" for now, simply flipping the order of if would be fine.
(This affects the Chemical "Diviber × Werewolf" case, but I think it's acceptable.)

Alternatively, we could use accessMainLevel to check "main" jobs before others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants