Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: column-reverse not working properly #25

Closed
pROFESOR11 opened this issue Dec 27, 2020 · 6 comments
Closed

Bug: column-reverse not working properly #25

pROFESOR11 opened this issue Dec 27, 2020 · 6 comments

Comments

@pROFESOR11
Copy link

Hi,
It works well with direction="column", but when direction is set to column-reverse, the views are not aligned and coloredIcons are not drawn from bottom to up.

<Rating
        rated={0.5}
        totalCount={1}
        ratingColor="#f1c644"
        ratingBackgroundColor="#d4d4d4"
        size={100}
        readonly
        icon="ios-star"
        direction="column" // direction="column-reverse"
      />
direction="column" direction="column-reverse"
image image
@ui-ninja
Copy link
Owner

ui-ninja commented Jan 6, 2021

@pROFESOR11 Strange. Demo folder has example which uses the "column-reverse" and it works fine. Can you share parent wrapper code as well?

@pROFESOR11
Copy link
Author

pROFESOR11 commented Jan 6, 2021

@ui-ninja Here you are:

export default function App() {
  return (
    <View style={styles.container}>
      <Rating
        rated={0.5}
        totalCount={1}
        ratingColor="#f1c644"
        ratingBackgroundColor="#d4d4d4"
        size={100}
        readonly // by default is false
        icon="ios-star"
        direction="column-reverse" // anyOf["row" (default), "row-reverse", "column", "column-reverse"]
      />
    </View>
  );
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    backgroundColor: '#fff',
    alignItems: 'center',
    justifyContent: 'center',
  },
});

I've also created a snack: https://snack.expo.io/@profesor/smart-orange

@ui-ninja
Copy link
Owner

ui-ninja commented Jan 6, 2021

Well this is what i see on snack shared.. looks fine to me

image

@pROFESOR11
Copy link
Author

pROFESOR11 commented Jan 6, 2021

@ui-ninja Could you try on iOS?

@ui-ninja
Copy link
Owner

ah! I see the issue now. Will fix and release minor patch soon

@ui-ninja
Copy link
Owner

@pROFESOR11 released a new version https://github.com/ui-ninja/react-native-rating-element/releases/tag/5.4.0
update the pkg and see if it resolves the bug? Reopen if it doesn't fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants