onIconTap should fire even if readonly is true

[Relax594]

I know it's by design, but why? I don't see any reason for it. Even if the Rating is readonly, i want to know where a user tapped (to toggle tooltips in my case).

react-native-rating-element/src/Rating/components/IconBar.js

Line 31 in eafbde2

if (!readonly) {

If you want to keep it this way, at least note it in the docs.

Regards

[ui-ninja]

I don't think it will make sense to trigger onIconTap if readonly is passed. For your usecase, simply don't make it readonly..

If you want to keep it this way, at least note it in the docs.

I mentioned it under API table's row readonly that onPress wont be fired.. But I forgot to update it once I changed onPress to onIconTap. Will update soon in new minor version.
Anyway i have plans to make few changes in IconBar.

[Relax594]

For your usecase, simply don't make it readonly..

haha honestly, i never thought about this 💯

Thanks a lot!