Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UpgradeAdapter in Angular 2.2.3 #24

Closed
trumbitta opened this issue Nov 30, 2016 · 8 comments
Closed

New UpgradeAdapter in Angular 2.2.3 #24

trumbitta opened this issue Nov 30, 2016 · 8 comments
Milestone

Comments

@trumbitta
Copy link

I can't find a way to make it work with the new way of using the UpgradeAdapter with Angular 2.2.3.

Ref: https://angular.io/docs/ts/latest/guide/upgrade.html

@jonrimmer
Copy link
Contributor

I have hacked in support for upgrade/static into my copy of ng1-to-ng2. I also have a modified copy of sample-app-ng1-to-ng2 that shows how to use it.

Hopefully this will be useful to any looking for a temporary workaround, at least. I could tidy it up into a pull request together if @christopherthielen thinks the approach looks sound?

@jonrimmer
Copy link
Contributor

I have updated my hack a bit now I better understand how UpgradeModule works. You no longer need to call uiRouterNgUpgrade.setNg2Injector(), as it's possible to get the ng2 injector from the ng1 injector (the static upgrader just changed the name its provided under).

@mischkl
Copy link

mischkl commented Feb 28, 2017

@christopherthielen is there any chance of using this patch (or the findings within it) to enable AOT support? (This is the last thing holding us back from integrating Angular 2 in our existing Angular 1 app.) ;)

@vladtar
Copy link

vladtar commented Mar 6, 2017

+1

1 similar comment
@AymanNatsheh
Copy link

+1

@RaphyLi
Copy link

RaphyLi commented Apr 20, 2017

@jonrimmer do you try recently your fork? Because a try to implement them in my project, but when upgrade the $uiRouter the injector is undefined.

@jonrimmer
Copy link
Contributor

@RaphyLi No, not for a while. There is a now an angular4 branch in this project. I would suggest trying that instead.

@christopherthielen christopherthielen added this to the 3.0.0 milestone May 15, 2017
@christopherthielen
Copy link
Member

Thanks @jonrimmer.
I've merged your changes into master and released it as @uirouter/angular-upgrade version 3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants