Empty links by ng2 uiSref directive

[christopherthielen]

From @artaommahe on January 8, 2017 20:16

uiSref directives binds 'null' string to href on provided null or empty string '' state.

current behavior

<!-- template -->
<a [uiSref]="null">smth</a>
<a [uiSref]="''">smth</a>

<!-- result -->
<a href="null">smth</a>

expected no href attribute (null property value?)

<!-- result -->
<a>smth</a>

It's required for dynamic links when for some cases href should be empty and link clicks does not trigger any state changes (access rights check e.x.)

Copied from original issue: angular-ui/ui-router#3248

[christopherthielen]

From @artaommahe on January 9, 2017 20:16

Fixed expected result html, due to empty href forced to reload page

[gcca]

I created a PR. But the bug cannot be shown on unit test with PhantomJS (unlike Firefox or Chrome launcher).

[rochapablo]

None of this is working:

<li *ngFor="let item of items">
   <a [uiSref]="item.link">{{ item.title }}</a>
   <a uiSref="item.link">{{ item.title }}</a>
   <a uiSref=".link">{{ item.title }}</a>
</li>

What could I be doing wrong?

[rochapablo]

Never mind, the problem was my items links which was

[
   { link: '/stores', title: 'Stores' }
]

Just removed the / and all worked.