Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng2: deep rxjs imports? #28

Closed
christopherthielen opened this issue Jan 21, 2017 · 3 comments
Closed

ng2: deep rxjs imports? #28

christopherthielen opened this issue Jan 21, 2017 · 3 comments

Comments

@christopherthielen
Copy link
Member

From @christopherthielen on October 13, 2016 17:43

We're currently importing from rxjs/Rx like:

import { Observable } from "rxjs/Rx";
import { ReplaySubject } from "rxjs/Rx";
import {Subscription, ReplaySubject} from "rxjs/Rx";

we might be able to do deep imports instead, so people don't have to load the entire rxjs/Rx package.

Need some research on the proper approach to allow users to either load the entire rxjs as a bundle, or build their own using webpack, etc.

Copied from original issue: angular-ui/ui-router#3087

@christopherthielen
Copy link
Member Author

From @bfricka on November 16, 2016 19:8

I think for ng2 this is an important issue. Here are some suggestions:

  • Source repo should be refactored as you mention
  • ng2 build should require peer dependency of rxjs as Angular 2 does. Since this is the standard practice it doesn't add anything that this community isn't already familiar with.
  • ng2 build should chunk out vendor deps and exclude from bundle

As it stands the overhead associated w/ this is too large for us to use ui-router, even though we desperately want to (the angular 2 router is turning into a nightmare for complex routing).

Where are your thoughts on moving this forward? Is there something I can do to help w/ the builds / refactoring?

@christopherthielen
Copy link
Member Author

From @aitboudad on November 18, 2016 17:3

see #5

@christopherthielen
Copy link
Member Author

fixed by 964c99f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant