Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 17 support #986

Closed
kevinzli opened this issue Jan 5, 2024 · 4 comments · Fixed by #987
Closed

Angular 17 support #986

kevinzli opened this issue Jan 5, 2024 · 4 comments · Fixed by #987

Comments

@kevinzli
Copy link

kevinzli commented Jan 5, 2024

We are in the midst of upgrading our project to Angular 17 and would love it if you could release a new version with v17 support!

@wawyed
Copy link
Member

wawyed commented Jan 5, 2024

My time is limited so PRs are welcome!

@Sabbacus
Copy link

Sabbacus commented Jan 8, 2024

We have overridden the UI Router Angular dependencies with Angular 17, and we have used it in production for about a month now without any issues. Perhaps it works for you as well?
That said, official Angular 17 support would be appreciated.

"overrides": {
"@uirouter/angular": {
"@angular/animations": "17.0.7",
"@angular/common": "17.0.7",
"@angular/core": "17.0.7",
"@angular/forms": "17.0.7"
}
}

@kevinzli
Copy link
Author

kevinzli commented Jan 9, 2024

I am trying to do development of @uirouter/angular locally, so I followed the development instructions https://github.com/ui-router/angular/blob/master/CONTRIBUTING.md#developing.

When I ran 'npm install' command in uirouter/ng2 project, I got the following npm error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: @uirouter/angular@12.0.0
npm ERR! Found: @angular/common@16.2.12
npm ERR! node_modules/@angular/common
npm ERR! dev @angular/common@"^16.0.0" from the root project
npm ERR! peer @angular/common@"16.2.12" from @angular/platform-server@16.2.12
npm ERR! node_modules/@angular/platform-server
npm ERR! peerOptional @angular/platform-server@"^16.1.0" from @angular-devkit/build-angular@16.1.2
npm ERR! node_modules/@angular-devkit/build-angular
npm ERR! dev @angular-devkit/build-angular@"^16.0.0" from the root project
npm ERR! 1 more (jest-preset-angular)
npm ERR! 2 more (@angular/platform-browser, @angular/service-worker)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"16.1.3" from @angular/platform-browser-dynamic@16.1.3
npm ERR! node_modules/@angular/platform-browser-dynamic
npm ERR! dev @angular/platform-browser-dynamic@"^16.0.0" from the root project
npm ERR! peer @angular/platform-browser-dynamic@">=13.0.0 <17.0.0" from jest-preset-angular@13.1.1
npm ERR! node_modules/jest-preset-angular
npm ERR! dev jest-preset-angular@"^13.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!

Anyone got the same error?

@wawyed
Copy link
Member

wawyed commented Jan 11, 2024

I am trying to do development of @uirouter/angular locally, so I followed the development instructions https://github.com/ui-router/angular/blob/master/CONTRIBUTING.md#developing.

When I ran 'npm install' command in uirouter/ng2 project, I got the following npm error:

npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: @uirouter/angular@12.0.0 npm ERR! Found: @angular/common@16.2.12 npm ERR! node_modules/@angular/common npm ERR! dev @angular/common@"^16.0.0" from the root project npm ERR! peer @angular/common@"16.2.12" from @angular/platform-server@16.2.12 npm ERR! node_modules/@angular/platform-server npm ERR! peerOptional @angular/platform-server@"^16.1.0" from @angular-devkit/build-angular@16.1.2 npm ERR! node_modules/@angular-devkit/build-angular npm ERR! dev @angular-devkit/build-angular@"^16.0.0" from the root project npm ERR! 1 more (jest-preset-angular) npm ERR! 2 more (@angular/platform-browser, @angular/service-worker) npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer @angular/common@"16.1.3" from @angular/platform-browser-dynamic@16.1.3 npm ERR! node_modules/@angular/platform-browser-dynamic npm ERR! dev @angular/platform-browser-dynamic@"^16.0.0" from the root project npm ERR! peer @angular/platform-browser-dynamic@">=13.0.0 <17.0.0" from jest-preset-angular@13.1.1 npm ERR! node_modules/jest-preset-angular npm ERR! dev jest-preset-angular@"^13.0.0" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution. npm ERR!

Anyone got the same error?

You are supposed to use yarn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants