Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests and CI build are failing #29

Closed
skoblenick opened this issue Jan 15, 2017 · 2 comments
Closed

Unit tests and CI build are failing #29

skoblenick opened this issue Jan 15, 2017 · 2 comments

Comments

@skoblenick
Copy link

Checkin 588dd99#diff-aa061986504f2cc13cc1174b6c24c91b has caused your unit tests and ci build to fail.

Would suggest turning on Branch protection in GitHub to ensure your build passes before allowing lands especially to master.
@skoblenick
Copy link
Author

Pull request #30 fixes the issue.

@christopherthielen
Copy link
Member

Fixed now.

Thanks, I really appreciate the report and PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skoblenick @christopherthielen