string parameters are url encoding issue

[paolosanchi]

The value of any parameter is urlencoded to the route, but it isn't urldecoded when converted back to parameter, this causes the engine detect it as changed and it causes a navigation.

format()

      // If the parameter type is "raw", then do not encodeURIComponent
      if (param.raw) return acc + encoded;
      // Encode the value
      return acc + encodeURIComponent(<string>encoded);

exec()

    for (let i = 0; i < nPathSegments; i++) {
      const param: Param = pathParams[i];
      let value: any | any[] = match[i + 1];

      // if the param value matches a pre-replace pair, replace the value before decoding.
      for (let j = 0; j < param.replace.length; j++) {
        if (param.replace[j].from === value) value = param.replace[j].to;
      }
      if (value && param.array === true) value = decodePathArray(value);
      if (isDefined(value)) value = param.type.decode(value);
      values[param.id] = param.value(value);
    }
    searchParams.forEach(param => {
      let value = search[param.id];
      for (let j = 0; j < param.replace.length; j++) {
        if (param.replace[j].from === value) value = param.replace[j].to;
      }
      if (isDefined(value)) value = param.type.decode(value);
      values[param.id] = param.value(value);
    });

I think this would be solved change the exec() to something like this:

    for (let i = 0; i < nPathSegments; i++) {
      const param: Param = pathParams[i];
      let value: any | any[] = match[i + 1];

      // if the param value matches a pre-replace pair, replace the value before decoding.
      for (let j = 0; j < param.replace.length; j++) {
        if (param.replace[j].from === value) value = param.replace[j].to;
      }
      if (value && param.array === true) value = decodePathArray(value);
      if (isDefined(value)){
		value = param.type.decode(value);
		if(typeof value === 'string' && !param.raw){
			value = decodeURIComponent(value);
		}
	  }
      values[param.id] = param.value(value);
    }
    searchParams.forEach(param => {
      let value = search[param.id];
      for (let j = 0; j < param.replace.length; j++) {
        if (param.replace[j].from === value) value = param.replace[j].to;
      }
      if (isDefined(value)){
		value = param.type.decode(value);
		if(typeof value === 'string' && !param.raw){
			value = decodeURIComponent(value);
		}
	  }
      values[param.id] = param.value(value);
    });

[thekip]

Same issue here. Interesting that with AngularJS bindings I didn't encountered this issue, but when I switched to Angular (current one) it appeared (they both should use the same version of core and the same UrlMatcher).

Related issue in ui-router/angular repo ui-router/angular#340

[thekip]

@christopherthielen FYI

[paolosanchi]

Same issue here. Interesting that with AngularJS bindings I didn't encountered this issue, but when I switched to Angular (current one) it appeared (they both should use the same version of core and the same UrlMatcher).

Related issue in ui-router/angular repo ui-router/angular#340

I work with Angular (not AngularJs) so i didn't aware of this, Maybe angularjs does something special to urls itself, like to urldecode automatically.

[stale]

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs.

This does not mean that the issue is invalid. Valid issues
may be reopened.

Thank you for your contributions.

[christopherthielen]

FYI this was fixed in core@6.0.6 #618