Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous redirects from onBefore can cause infinite redirect loop #6

Closed
christopherthielen opened this issue Nov 12, 2016 · 0 comments
Labels

Comments

@christopherthielen
Copy link
Member

88052bf added 20+ redirect loop detection, but it only was checked

  • when the redirected transition was run
  • after the sync hooks were processed

This meant a synchronous hook (onBefore) which returned a redirect could avoid the loop detection.

Moving this logic to the Transition.redirect() function should detect the 20+ loops at a more appropriate time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant