feat(*): Allow React functional components #331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rational
The release of Hooks allows to avoid classes completely, so it might be reasonable to allow functions to be used as top level components.
Changes
I've added a check to make sure
cmp
is a function and since Angular's directives and components are passed as strings it should be safe to attribute that component to React.React does similar check internally and
ui-router
's heuristic with these changes included would be similar.@christopherthielen I'd appreciate your feedback on this.