Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example not following the documentation #297

Open
QuentinLuc opened this issue Oct 9, 2018 · 1 comment
Open

Example not following the documentation #297

QuentinLuc opened this issue Oct 9, 2018 · 1 comment

Comments

@QuentinLuc
Copy link

QuentinLuc commented Oct 9, 2018

At this line:

import uiRouter from "@uirouter/angularjs";

There is an import to "@uirouter/angularjs" but in the documentation it's written

Remove angular-ui-router (or @uirouter/angularjs) from your AngularJS app's package.json and replace it with @uirouter/angular-hybrid. Add the @angular/* dependencies.

Therefore what should I do?
If I remove it from the app's package.json, I cannot import it otherwise I got a compilation error. However, in the live example, I noticed that the @uirouter/angularjs lib has been loaded by Webpack.

I'm asking this question because I kept it in the package.json then removed it and my app doesn't run anymore (I'm using SystemJS) because I get an error in Chrome:
image

Sould I keep it and reference it using some specific path (like this one: "@uirouter/angular-hybrid/node_modules/@uirouter/angularjs") which works btw?

Thanks!

@k0nG
Copy link

k0nG commented Feb 7, 2019

I've found changing it to import '@uirouter/angular-hybrid'; and adding @angular/router to my package.json works for me if that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants