Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with running the app locally on hybrid-angular1-angular2 branch #29

Closed
vucalur opened this issue Sep 15, 2016 · 2 comments
Closed

Comments

@vucalur
Copy link

vucalur commented Sep 15, 2016

Could you please revise committed settings?

Steps I take:

  1. $ npm install
  2. $ npm run dev (BTW: inconsistency between branches: dev vs. start in master branch)
  3. Opened http://localhost:3000, got following error:
    Unhandled Promise rejection: (SystemJS) Unable to dynamically transpile ES module as SystemJS.transpiler set to false.
  4. After changing in to true in config.js, I get: Unhandled Promise rejection: (SystemJS) name.lastIndexOf is not a function

If it's my fault and I'm doing sth wrong, perhaps writing a short note on running the stuff in README.md could help.

@christopherthielen
Copy link
Member

I moved the code from that branch into its own repository. Can you try https://github.com/ui-router/sample-app-ng1-to-ng2

git clone https://github.com/ui-router/sample-app-ng1-to-ng2.git
cd sample-app-ng1-to-ng2
npm install && npm start

@vucalur
Copy link
Author

vucalur commented Sep 16, 2016

Thanks. Seems to be working.
I only had to change port from 3000 to 3001 in index.html. Browser-sync has bound to 3001 for me.

IMHO keeping 2 versions in separate branches is more lucid. One can cherry-pick changes from one to another.
If you'd rather keep it a separate repo, I suggest adding a note about branch depreciation. Deleting a branch with historical commits doesn't sound like a good idea, unless they're moved somewhere else.

With that being said, thanks for a great learning resource!

@vucalur vucalur closed this as completed Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants