Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build process fails when attempting to mangle the code base #34

Closed
schester44 opened this issue Mar 16, 2017 · 1 comment
Closed

Build process fails when attempting to mangle the code base #34

schester44 opened this issue Mar 16, 2017 · 1 comment

Comments

@schester44
Copy link

I'm using webpack's uglifyjs plugin. The code doesn't work if I have the plugins mangle option set to true. I'm getting an injector provider error on build due to the code not being min-safe. I understand why its happening but I can't figure out the necessary steps needed to not make it happen. I'd imagine the primary root cause would be within ngmodule.js where we actually load everything up.

@christopherthielen
Copy link
Member

The codebase wasn't minification safe until just recently:

2b9d8f8

mangle works now, and you can see all the changes required in the above commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants