Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comments in the tsconfig.json file #239

Closed
stephaneeybert opened this issue Apr 20, 2020 · 1 comment
Closed

Allow comments in the tsconfig.json file #239

stephaneeybert opened this issue Apr 20, 2020 · 1 comment

Comments

@stephaneeybert
Copy link

stephaneeybert commented Apr 20, 2020

My tsconfig.json file contains:

  "exclude": [
    // IDEs should not type-check the different node_modules directories of the different packages.
    // This would cause the IDEs to be slower and also linters would check the node_modules.
    "node_modules/",
    "typings"
  ]

The ngd command failed:

14:55 $ ngd
[14:55:36] using tsconfig: /home/stephane/dev/js/projects/angular/musicng/tsconfig.json
internal/modules/cjs/loader.js:1188
    throw err;
    ^

SyntaxError: /home/stephane/dev/js/projects/angular/musicng/tsconfig.json: Unexpected token / in JSON at position 1017

After removing the comments, the same command succeeded.

@christopherthielen
Copy link
Member

What is ngd? I think you have the wrong repo. Perhaps you meant to be here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants