Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with Internet Explorer and .assign method #30

Open
krptodr opened this issue Feb 8, 2017 · 2 comments
Open

Error with Internet Explorer and .assign method #30

krptodr opened this issue Feb 8, 2017 · 2 comments
Labels

Comments

@krptodr
Copy link

krptodr commented Feb 8, 2017

Hello, there is an issue when declaring the plugin. It seems there is not alternative to checking for the assign method when using IE.

Please have a look at http://stackoverflow.com/questions/35215360/getting-error-object-doesnt-support-property-or-method-assign

@christopherthielen
Copy link
Member

We should replace usage of Object.assign with the extend function from ui-router-core.

@p0lar-bear
Copy link

p0lar-bear commented Oct 19, 2017

I decided to try and shim this for my AngularJS app by adding:

if (!$window.Object.assign) {
    $window.Object.assign = $window['@uirouter/angularjs'].extend;
}

Before the call to register the Visualizer with my uiRouterInstance, and that much worked.

However, that leads to another fatal stop because the Visualizer uses Promise and IE 11 doesn't have that. To work around that I added the es6-promise package to my project and added it to the list of third party scripts my build task compiles, works now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants