Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependency preact to 8.2.xx #35

Closed
AnWeber opened this issue Aug 21, 2017 · 4 comments
Closed

update dependency preact to 8.2.xx #35

AnWeber opened this issue Aug 21, 2017 · 4 comments

Comments

@AnWeber
Copy link

AnWeber commented Aug 21, 2017

I am using latest visualizer with Typescript 2.4.2. In the build I get this error:

ERROR in ...\node_modules\@uirouter\visualizer\node_modules\preact\dist\preact.d.ts
(40,17): error TS2559: Type 'Component<PropsType, StateType>' has no propert

This error is already fixed in preactjs/preact#735 and preact v8.2 is already released, but visualizer keeps installing v7.xx.

Please update the depencency. Currently I am using a workaround and shinkwrap the version.

@trumbitta
Copy link

Still a problem.

Also, Angular 5 released yesterday uses Typescript 2.4.x

@elboman
Copy link
Member

elboman commented Nov 3, 2017

I'm not sure how this is still a problem as current preact version is 8.2.5: https://github.com/ui-router/visualizer/blob/master/package.json#L38

@trumbitta
Copy link

@elboman you're right, I just had to update @uirouter/visualizer to 5.0.0 - released a couple days ago :)

@elboman
Copy link
Member

elboman commented Nov 3, 2017

awesome, glad it's fixed 😄

@elboman elboman closed this as completed Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants