Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE Test Library Timeout #411

Merged
merged 6 commits into from Jan 30, 2023
Merged

FE Test Library Timeout #411

merged 6 commits into from Jan 30, 2023

Conversation

Siolto
Copy link
Collaborator

@Siolto Siolto commented Jan 24, 2023

Fiori Elements TestLib will use the same timeouts as defined in our property waitForUI5Timeout. There is also a new hint in the documentation which tells, that every timeout higher than 30 seconds requires to increase the session script timeout as well.

client-side-js/testLibrary.js Show resolved Hide resolved
client-side-js/testLibrary.js Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
@nair-sumesh
Copy link
Contributor

Waiting eagerly for this change 👀

Copy link
Contributor

@vobu vobu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's get through CI, then good to go :)

@vobu vobu merged commit 9d84414 into main Jan 30, 2023
@vobu vobu deleted the feat/fe_lib_timeout branch January 30, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants