Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPhone X bottom margin #208

Closed
3 tasks done
ShockUtility opened this issue Dec 6, 2017 · 7 comments
Closed
3 tasks done

iPhone X bottom margin #208

ShockUtility opened this issue Dec 6, 2017 · 7 comments
Labels
Milestone

Comments

@ShockUtility
Copy link

ShockUtility commented Dec 6, 2017

New Issue Checklist

Issue Description

There is a bug in the bottom margin.

  • Tabman 1.1.2
  • Xcode 9.2 (9C40b)
  • iOS 11.2 (15C107)

Other useful things

tabman01

tabman02

@msaps
Copy link
Member

msaps commented Dec 7, 2017

@ShockUtility okay thanks, I'll check it out! 👍

@msaps msaps added the bug label Dec 7, 2017
@msaps msaps modified the milestones: 1.2.0, 1.1.3 Dec 7, 2017
@msaps
Copy link
Member

msaps commented Dec 8, 2017

@ShockUtility this actually looks as though it's something that was introduced in iOS 11.2. Tabman sets contentInsetAdjustmentBehavior = .never on all scroll views to allow for the custom insetting behaviour, and previous versions of iOS 11, this meant that no element of the scroll view's contentInset was adjusted by UIKit.

Starting in 11.2, however the bottom safe area height seems to be automatically included and adjusts the contentInset no matter what the contentInsetAdjustmentBehavior is set to.

I'll see if I can find a workaround and update Tabman accordingly. Have also raised a radar rdar/35933138.

@msaps
Copy link
Member

msaps commented Dec 8, 2017

iOS 11.1 vs 11.2 at the bottom of scroll view with contentInsetAdjustmentBehavior = .never.

screen shot 2017-12-08 at 14 41 46

@msaps
Copy link
Member

msaps commented Dec 12, 2017

Resolved in 1.1.3 👍

@sngsng
Copy link

sngsng commented Dec 20, 2017

This issue still exists in 1.1.3 😢

@msaps
Copy link
Member

msaps commented Dec 20, 2017

@sngsng please can you try using Tabman 1.2.0 with Pageboy 2.2.0? I’ve found the issue in a UIPageViewController change that came with iOS 11.2, and have put a workaround in the latest version of Pageboy..

Sent with GitHawk

@sngsng
Copy link

sngsng commented Dec 21, 2017

I tried it and it works fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants