Accessibility #403
Merged
Accessibility #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iv-mexx
commented
Mar 17, 2019
This was referenced Apr 14, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #399
Originally I just wanted to add
accessibilityLabelto Tab Buttons to use them in UI Tests.However, when I looked into this I found that Tabman was not accessible at all.Whit these changes, Tabman is now accessibly without any changes required by Users of Tabman.
The most important change was for
TMBarViewto implement the (informal) (UIAccessibilityContainer Protocol)[https://developer.apple.com/documentation/uikit/accessibility/uiaccessibilitycontainer], which basically just needs to return the elements in the container (in this case the buttons).