Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no aria-expanded for toggle modal-dialogs #4702

Closed
MoppieMop opened this issue Dec 20, 2022 · 1 comment
Closed

no aria-expanded for toggle modal-dialogs #4702

MoppieMop opened this issue Dec 20, 2022 · 1 comment
Labels
! Bug Something which isn't working as expected

Comments

@MoppieMop
Copy link

UIkit Version

3.15.18

Actual Behavior

The recommend markup to open a modal-dialog is with uk-toggle. BUT uk-toggle adds aria-expanded="false" to the HTML-element. This is wrong behaviour for modal-dialogs (see WCAG).

Expected Behavior

If I use uk-toggle AND the target is a uk-modal THEN there should not be an automatic aria-expanded on the uk-toggle.
@MoppieMop MoppieMop added the ! Bug Something which isn't working as expected label Dec 20, 2022
@janschoenherr
Copy link
Contributor

This has been fixed with 3.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
! Bug Something which isn't working as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janschoenherr @MoppieMop