Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter + sort broken #4841

Open
Hurmeli opened this issue Jul 21, 2023 · 2 comments
Open

Filter + sort broken #4841

Hurmeli opened this issue Jul 21, 2023 · 2 comments
Labels
! Bug Something which isn't working as expected

Comments

@Hurmeli
Copy link

Hurmeli commented Jul 21, 2023

UIkit Version

3.16.22

Actual Behavior

When Filter Control is using sort, it will select first two options instead of switching between them. See the example. This exact code worked in older version of UiKit just fine.

Note that I left out the sortable cards and only left in the buttons to make it more clear. But if you remove the sort option from the first three buttons, you will see how it starts to work.

Expected Behavior

Filter should switch between first 3 options, but instead it marks first 2 active at the same time. Slightly unclear which of them actually takes effect.

Reproduction Link

https://codepen.io/Hurme/pen/wvQxBYx

The problem seems very similar to this earlier closed problem:
#3670

@Hurmeli Hurmeli added the ! Bug Something which isn't working as expected label Jul 21, 2023
@janschoenherr
Copy link
Contributor

I think having sort and filter on the same button is not supported currently.

@Hurmeli
Copy link
Author

Hurmeli commented Aug 1, 2023

Do you think it would be possible to add this feature back? It did work in the past just fine as I mentioned.

In my case the website has feed of articles set in 'All|News|Events', where first two are sorted by release date the last one is sorted by events starting date. Having a separate set of buttons for sorting makes no sense in this and many other cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
! Bug Something which isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants