Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tests on pypi release #37

Closed
Jenselme opened this issue Jun 28, 2015 · 2 comments
Closed

Include tests on pypi release #37

Jenselme opened this issue Jun 28, 2015 · 2 comments

Comments

@Jenselme
Copy link
Contributor

Hi,

I am currently packaging this software for fedora. I rely on pypi to get the sources (they have cleaner URLs than github) and it would be great to launch the tests while doing the packaging. Can you include toml_test.py and toml_test3.py in the pypi distribution?

For information, the review URL: https://bugzilla.redhat.com/show_bug.cgi?id=1231981

@uiri
Copy link
Owner

uiri commented Jun 28, 2015

Hey,

toml_test.py and toml_test3.py are test harnesses for running BurntSushi's test suite against the library. If you don't want to use BurntSushi's test suite during packaging, would those test harnesses still be useful? Per the review, I wouldn't mind including a simple script which ensures that the library imports properly if you think that would be more useful.

@Jenselme
Copy link
Contributor Author

I should have read TESTING before asking. The script that ensure that the lib imports won't be needed and no the test files won't be useful without BurntSushi's package so it doesn't really make sense to include them on pypi. BurntSushi is available on fedora, I will just make a patch to get and launch the tests.

Thanks for your quick reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants