Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what are degenerated edges and where do they come from? #16

Open
smason opened this issue Dec 8, 2021 · 1 comment
Open

what are degenerated edges and where do they come from? #16

smason opened this issue Dec 8, 2021 · 1 comment

Comments

@smason
Copy link
Contributor

smason commented Dec 8, 2021

SALOME's shape gluer code has various branches that are never tested because they are behind if(BRep_Tool::Degenerated(edge)) tests that never come up true. The docs aren't particularly here, currently documenting this function as:

Returns True if the edge is degenerated.

Would be good to figure out how to generate a geometry that has solids containing degenerated edges and know what the "right thing" to do when gluing shapes in the presence of them.

@smason
Copy link
Contributor Author

smason commented Dec 17, 2021

The step format uses the term "degenerate" in reference to pcurves, saying:

A Degenerate_pcurve is a type of Point that is defined as a parameter space curve, but in three-dimensional model space it collapses to a single point. It is thus a subtype of Point, not of Curve.

which would make sense to ignore for edge operations, as what's interesting is the point along this curve, not the curve itself.

Not sure if they're talking about the same thing though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant