Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: plasma is not displayed if rotation_angle is 360 #61

Closed
RemDelaporteMathurin opened this issue Jul 12, 2020 · 2 comments
Closed

BUG: plasma is not displayed if rotation_angle is 360 #61

RemDelaporteMathurin opened this issue Jul 12, 2020 · 2 comments

Comments

@RemDelaporteMathurin
Copy link

Code to reproduce :

import paramak

plasma = paramak.Plasma(minor_radius=200, major_radius=620, triangularity=0.55, elongation=1.85)
plasma.solid

When the argument rotation_angle is not given, the .solid method doesn't display the plasma.

@shimwell
Copy link
Collaborator

Ah yes this is a strange one.

When the rotation angle is not specified then it defaults to 360 degrees. This makes a complete spline where the start and end surface connect. This sometimes breaks but a rotation angle of less than 360 (e.g. 359) works in the visualization

There is a bug in OCC 7.3 which cascades to CadQuery and onto the Paramak when such shapes don't get created.

However it works if you export the stp file then everything appears to work

anyway the bug is getting fixed upstream and more details can be found here
CadQuery/cadquery#259

It might take a while for the fix to propagate through the various stages and appear in the conda install

sorry about this

@RemDelaporteMathurin RemDelaporteMathurin changed the title BUG: plasma is not displayed if rotation_angle is not specified BUG: plasma is not displayed if rotation_angle is 360 Aug 27, 2020
@RemDelaporteMathurin
Copy link
Author

@shimwell the update of the docker image seems to have fixed this. If the new image is used in the CI then I can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants