Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windux: setVolume throws UnimplementedError although it has been implemented in Rust. #126

Open
kestlerio opened this issue Oct 13, 2023 · 0 comments

Comments

@kestlerio
Copy link

Calling Soundpool.setVolume(...) under Windows throws an UnimplementedError although there seems to be an implementation in the Rust code.

In soundpool/soundpool_windux/lib/soundpool.windux.dart we can see

  @override
  Future<void> setVolume(int poolId, int? soundId, int? streamId,
      double? volumeLeft, double? volumeRight) {
    throw UnimplementedError('setVolume() has not been implemented');
  }

However, the Windux documentation says that set_volume has been implemented and also the Rust code in soundpool/soundpool_windux/rust/src/soundpool.rs seems to have this implementation.

                SetVolume(sound_id, volume) => {
                    set_volume(&mut sounds, &streams_tx, sound_id, volume);

Maybe the functionality is really there but the calling Dart code just has not been updated?
Anyway, thank you very much for this library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant