Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pimple 3+ #3

Open
ghost opened this issue Jul 31, 2015 · 4 comments
Open

Pimple 3+ #3

ghost opened this issue Jul 31, 2015 · 4 comments

Comments

@ghost
Copy link

ghost commented Jul 31, 2015

Does this not work with Pimple 3 and above?

@meetmatt
Copy link
Contributor

It can work, but requires a BC break: Wart has to extend from Container instead of Pimple.
I've created a separate branch, tag and package if you need Pimple 3:
https://github.com/meetmatt/wart/tree/3.0
https://github.com/meetmatt/wart/tree/3.0.0
https://packagist.org/packages/meetmatt/wart#3.0.0
Probably it could be a main branch, but I am not an original creator of this package

@thewunder
Copy link

@meetmatt How about doing a pull request, and @ukautz could do a release, I have a large project using pimple 3 and this would be the easiest way to add auto-resolution

@meetmatt
Copy link
Contributor

@thewunder sure, I can easily do it.
Will get back to this topic after working hours.

@meetmatt meetmatt mentioned this issue Oct 11, 2018
@meetmatt
Copy link
Contributor

@thewunder @ukautz here's the PR: #5
Let me know if you need anything more :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants