Fix support for host/hosts placeholders for ipv6 addresses #1030
+121
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cosmo0920 can I get a review of this PR? |
7 tasks
|
@cosmo0920 Any progress on this? |
|
Hi, sorry for long delayed reviewing. |
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
cosmo0920
approved these changes
Nov 20, 2023
|
Released this change as v5.4.0. Thank you for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes support for host/hosts placeholders specifically for ipv6 addresses.
Before this fix, IPv6 addresses would not be parsed correctly after evaluating host/hosts for placeholders.
(check all that apply)
versionin gemspec are untouchedelasticsearch_dynamic(not required but recommended)