Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page activation context is always empty for push events #55

Closed
uklance opened this issue Apr 23, 2013 · 1 comment
Closed

Page activation context is always empty for push events #55

uklance opened this issue Apr 23, 2013 · 1 comment

Comments

@uklance
Copy link
Owner

uklance commented Apr 23, 2013

PushManagerImpl always passes EMPTY_EVENT_CONTEXT as the page activation context for push events

@see https://github.com/uklance/tapestry-cometd/blob/master/src/main/java/org/lazan/t5/cometd/services/internal/PushManagerImpl.java#L60

To fix this, PushTarget needs to be changed to add the page activation context in getInitData() (https://github.com/uklance/tapestry-cometd/blob/master/src/main/java/org/lazan/t5/cometd/components/PushTarget.java#L109).

The page activation context will need to be added to the ClientContext in AuthorizersImpl.getClientContext() (https://github.com/uklance/tapestry-cometd/blob/master/src/main/java/org/lazan/t5/cometd/services/internal/AuthorizersImpl.java#L74)

The solution might require a PageRenderRequestFilter to be contributed to the start of the PageRenderRequestHandler pipeline. The filter will set a thread local for the page activation context (very similar to RequestGlobals).

@uklance
Copy link
Owner Author

uklance commented Apr 28, 2013

Issue resolved in 0.9.16

@uklance uklance closed this as completed Apr 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant