Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task deleteScreenshot also deletes failed screenshots created by cypress #98

Closed
markbeaman44 opened this issue Aug 12, 2022 · 1 comment

Comments

@markbeaman44
Copy link

markbeaman44 commented Aug 12, 2022

Hi All,
I'm using the visual tool along with cypress assertions/validations, and I've noticed 2 things:
Please let me know if its an issue or I'm doing something wrong :)

1:
During my test it will execute some actions then assert, then visual-snapshot.
But if the assert failed - it should take a screenshot and store in folder, but when using the visual plugin - it doesnt.
I think its due to deleteScreenshot Task - it just deletes all screenshots instead of its own created one (I could be wrong)

When I disable getCompareSnapshotsPlugin(on, config) the failed cypress screenshots return (but now visual testing wont work).

Outcome with getCompareSnapshotsPlugin:
Screenshot 2022-08-12 at 15 11 12

Outcome without getCompareSnapshotsPlugin:
Screenshot 2022-08-12 at 15 12 31

2:
When setup correctly and loading Cypress open (version 10.4.0), it decides to create a random base image, before anything is executed and I dont know why this is happening - I assume it should only generate base image during test execution.

Setup:
Screenshot 2022-08-12 at 15 10 19

Issue:
Screenshot 2022-08-12 at 15 09 51
point 2 no longer an issue - turns out the image remained in comparison folder. Removing it, no longer generated a new one.

Let me know if more info is needed & thanks in advance

@markbeaman44
Copy link
Author

Closing ticket - it was addressed in this fix: dea83b0
Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant