feat: no need for local zip64 extra when streaming #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalc
force-pushed
the
no-zip64-local-extra-field
branch
from
60612c2
to
6a713be
Compare
michalc
changed the title
This was added in 62f8cf1, but it might not really have ever been needed, so removing it saves a few bytes. And stronger than that, libarchive/libarchive#1834 gives an argument that it even makes the ZIP file invalid. To give even more weight to the argument that this is ok, I made a few Zip64 files with data descriptors with InfoZIP. They did not have local Zip64 extra fields. If this were a problem, it probably would have been discovered by now.
michalc
force-pushed
the
no-zip64-local-extra-field
branch
from
6a713be
to
1130fdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in 62f8cf1, but it might not really have ever been needed, so removing it saves a few bytes. And stronger than that, libarchive/libarchive#1834 gives an argument that it even makes the ZIP file invalid.
To give even more weight to the argument that this is ok, I made a few Zip64 files with data descriptors with InfoZIP. They did not have local Zip64 extra fields. If this were a problem, it probably would have been discovered by now.