Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async head texture registration in MixinOptionsScreen causes crash when used with FancyMenu (and maybe other mods) #16

Closed
Keksuccino opened this issue Feb 15, 2024 · 1 comment

Comments

@Keksuccino
Copy link

Keksuccino commented Feb 15, 2024

Hey, dev of FancyMenu here!

One of my users reported a crash when having ukulib + FancyMenu installed.

This is caused by asynchronously registering the head texture of your config button in MixinOptionsScreen.

texManager.registerTexture(texture, new NativeImageBackedTexture(image));

Asynchronously loading the NativeImage is fine, but please consider registering the DynamicTexture/NativeImageBackedTexture in the main/render thread.
(I think asynchronously registering textures could be a bad idea in general, but I'm not 100% sure about that.)

Thank you very much and have a great day!

@uku3lig
Copy link
Owner

uku3lig commented Feb 15, 2024

thanks for reporting the issue! i will publish a release to modrinth shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants