Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure iframes are removed in browser context #44

Open
uladkasach opened this issue May 25, 2018 · 0 comments
Open

ensure iframes are removed in browser context #44

uladkasach opened this issue May 25, 2018 · 0 comments

Comments

@uladkasach
Copy link
Owner

we disable iframe removal in node.js context because JSDOM destroys the exported data along with the iframe.

Consider either manually duplicating the exported data before removing the iframe in node context or a better way of testing that iframes are removed in browser context.

additionally, ensure that iframes are in fact removed in browser context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@uladkasach