Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode throws IndexOutOfRangeException with certain incorrect input #8

Closed
hagis opened this issue Mar 10, 2015 · 4 comments
Closed

Comments

@hagis
Copy link

hagis commented Mar 10, 2015

A very useful library thanks! I stumbled upon a bug, which I thought I'd share:

[TestMethod]
public void TestHashIdsThrowsIndexOutOfRange()
{
var hashids = new Hashids("janottaa", 6);
var numbers = hashids.Decode("NgAzADEANAA=");
}

@epalm
Copy link

epalm commented Aug 10, 2015

1.1.0 was released on Jun 29, 2015. Was this a confirmed issue? I can't seem to reproduce it.

@hagis
Copy link
Author

hagis commented Aug 11, 2015

I don't know what you mean by a confirmed issue, but the test above consistently reproduced the error.

I would retest with the latest version, but I do not have access to a .net environment at the moment.

If you cannot reproduce, go ahead and close this issue.

@epalm
Copy link

epalm commented Aug 11, 2015

I meant "was the issue confirmed by the author?" The test above consistently works for me using v.1.0.1, though I can't find any commits that address the issue.

@ullmark
Copy link
Owner

ullmark commented Aug 14, 2015

sorry for the hold up, been on long vacation so have been away from the computer for some time. I'll add the test and see if it throws. if not, I'll close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants