Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate performance of ssbh_data -> ssbh_lib conversions #89

Open
ScanMountGoat opened this issue Sep 23, 2021 · 2 comments
Open

investigate performance of ssbh_data -> ssbh_lib conversions #89

ScanMountGoat opened this issue Sep 23, 2021 · 2 comments
Labels
ssbh_data High level data access

Comments

@ScanMountGoat
Copy link
Member

ScanMountGoat commented Sep 23, 2021 •
edited

The initial performance figures aren't looking too good for Anim. This could benefit from some benchmarking/profiling.

Anim -> AnimData: 726.5µs
AnimData -> Anim -> File: 31.1529ms
@ScanMountGoat ScanMountGoat added the ssbh_data High level data access label Sep 23, 2021
@ScanMountGoat
Copy link
Member Author

The bits.extend seems to copy one bit at a time. There should be some way to avoid multiple allocations per compressed buffer and potentially pool some of the bit sets together.

@ScanMountGoat
Copy link
Member Author

Allocating a single buffer and more intelligently setting the elements gives a roughly 4.5x speedup.

Anim -> AnimData: 677.5µs
AnimData -> Anim -> File: 6.845ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ssbh_data High level data access
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ScanMountGoat