Specify setuptools_scm config in pyproject.toml #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides multiple advantages: - It is the recommended way of using setuptools_scm - It makes it easier for tools to find this dependency and therefore build in a sandbox The previous behavior is still left in place to support older version of setuptools and pip that do not support PEP 517
|
Thanks! |
|
Hi, I'm considering dropping Python 2.7 soon. This PR hasn't been released yet. Do you need this (or think it should be) in a final release that also supports Python 2.7? Or is it okay to release it in an UltraJSON 3.0 that also drops support for Python 2.7? Thanks! |
|
Hey, Thanks for checking! |
|
Great, hope to have a 3.0 out with this in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides multiple advantages:
build in a sandbox
The previous behavior is still left in place to support older version
of setuptools and pip that do not support PEP 517
Fixes #380