Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indent and add test case #426

Merged
merged 1 commit into from Sep 19, 2020
Merged

Conversation

chenhan1218
Copy link
Contributor

Fixes #415

Changes proposed in this pull request:

  • Fix indent parameter parsing by correct the format.
  • Add test case for encode function with indent argument.

@chenhan1218
Copy link
Contributor Author

chenhan1218 commented Sep 17, 2020

$ pip install .
$ python -c 'import ujson; print(ujson.encode({"a":1}, indent=8))'  
{
        "a": 1
}

@hugovk hugovk merged commit 335ac83 into ultrajson:master Sep 19, 2020
@hugovk
Copy link
Member

hugovk commented Sep 19, 2020

Thank you!

@hugovk hugovk added changelog: Fixed For any bug fixes bug Something isn't working labels Sep 19, 2020
@chenhan1218 chenhan1218 deleted the fix-indent branch September 22, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog: Fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'indent' parameter for dumps doesn't indent properly in 3.0.0
2 participants