Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnicodeDecodeError on arm64/aarch64 #435

Merged
merged 1 commit into from Oct 9, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 9, 2020

Fixes #434

Changes proposed in this pull request:

The docs https://docs.python.org/3/library/functions.html#open say:

In text mode, if encoding is not specified the encoding used is platform dependent: locale.getpreferredencoding(False) is called to get the current locale encoding.

On a Mac, it's UTF-8, no problem.

On arm64/aarch64, it's ANSI_X3.4-1968.

@hugovk hugovk added bug Something isn't working changelog: Fixed For any bug fixes labels Oct 9, 2020
@hugovk hugovk merged commit 0b5b635 into ultrajson:master Oct 9, 2020
@hugovk hugovk deleted the fix-UnicodeDecodeError branch October 9, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog: Fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build problem of ujson 4.0.0 in Ubuntu arm64 Docker container
1 participant