Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch shebang for the manylinux-wheels script #465

Conversation

bwoodsend
Copy link
Collaborator

Fixes #464.

A whole day of scowling at it to discover that making this rather pathetic change somehow fixes it. Docker buildx is new and it is quite normal for its error messages to be odd but this one makes no sense for so many different reasons.

Some history:

  • I couldn't reproduce the error locally - it all runs perfectly fine on my machine.
  • The failure is almost certainly a change to the build environment although I can't tell what. Diffing the logs for the passing and failing runs I saw that:
    • The manylinux2014_aarch64 image had changed - but pinning it back to the old version fixed nothing
    • The Linux kernel version had updated - this is not exactly configurable
    • Docker-compose, buildx and qemu where all identical

So I've still got no idea what changed to cause the error to surface now and if it's likely to resurface. Here is a working build log. If that plays up again, I've found that ditching the dockerfile and replacing the docker buildx build command with just another docker run (like the other architectures) also works (again for no reason that I can see).

Making this insultingly trivial change somehow fixes the obscure and
locally unreproducible build errors on aarch64 docker reported in
ultrajson#464. Fixes ultrajson#464.
@codecov-commenter
Copy link

Codecov Report

Merging #465 (278e75b) into master (651cca5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   88.64%   88.64%           
=======================================
  Files           6        6           
  Lines        1629     1629           
=======================================
  Hits         1444     1444           
  Misses        185      185           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 651cca5...278e75b. Read the comment docs.

@hugovk hugovk added the changelog: Fixed For any bug fixes label Jun 12, 2021
@hugovk
Copy link
Member

hugovk commented Jun 12, 2021

Wow, one of those bugs! Thank you very much!

@hugovk hugovk merged commit ea7cb91 into ultrajson:master Jun 12, 2021
@bwoodsend
Copy link
Collaborator Author

Who'd have thought that running a script with bash and running a script with bash could be so different. I think that the latter will run ~/.bashrc and ~/.profile first but don't quote me on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aarch64 wheel deploy failing
3 participants